replace reviewdog action with official golangci action #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
commented
Jan 11, 2024
| @@ -121,7 +121,7 @@ func (m *mergeStmtGenerator) generateDeDupedCTE() string { | |||
| } | |||
|
|
|||
| // generateMergeStmt generates a merge statement. | |||
| func (m *mergeStmtGenerator) generateMergeStmt(unchangedToastColumns []string) string { | |||
| func (m *mergeStmtGenerator) generateMergeStmt(_unchangedToastColumns []string) string { | |||
There was a problem hiding this comment.
This parameter isn't used, so probably this is really bad for BQ where we'll run the same query 8 times. But that can be fixed in another PR
There was a problem hiding this comment.
this was causing issues for a customer: #1066
fixed in the linked PR
iskakaushik
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix lints